Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14 QA Added Content tests with various of data types #16824

Merged
merged 50 commits into from
Aug 27, 2024

Conversation

nhudinh0309
Copy link
Contributor

@nhudinh0309 nhudinh0309 commented Jul 26, 2024

Added Content tests with various of data types:

  • Image Cropper
  • Member Picker
  • Multiple Image Media Picker
  • Numeric

@nhudinh0309 nhudinh0309 changed the title V14 QA Added Content tests with Image Cropper data type V14 QA Added Content tests with various of data types Aug 5, 2024
Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had comments

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a comment

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments

await umbracoApi.documentType.ensureNameNotExists(documentTypeName);
await umbracoApi.document.ensureNameNotExists(contentName);
contentPickerDocumentTypeId = await umbracoApi.documentType.createDefaultDocumentTypeWithAllowAsRoot(contentPickerDocumentTypeName);
await umbracoUi.goToBackOffice();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed from the beforeEach?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we need to go to the back office after creating the content in some tests, this step should be defined in each test rather than in the beforeEach

@nhudinh0309 nhudinh0309 merged commit c5e5fa2 into v14/dev Aug 27, 2024
16 checks passed
@nhudinh0309 nhudinh0309 deleted the v14/QA/content-with-image-cropper-tests branch August 27, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants